ci: Fix docs release failing on detached HEAD#866
Merged
Conversation
When manual_release_docs.yaml is invoked with a commit SHA as ref (e.g. from doc_release_post_publish in on_master.yaml or from the stable release pipeline), actions/checkout leaves the repo in a detached HEAD state and the hand-rolled git push fails with "fatal: You are not currently on a branch." Switch to EndBug/add-and-commit with new_branch set to the default branch, and apply the same fix to manual_version_docs.yaml where the same latent bug existed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 48 48
Lines 2920 2920
=======================================
Hits 2530 2530
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
exactly the same changes as in apify/apify-client-python#741 that were already approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as apify/apify-client-python#741 — the SDK workflows have the identical bug.
When
manual_release_docs.yamlis invoked with a commit SHA asref(fromdoc_release_post_publishinon_master.yamlor frommanual_release_stable.yaml),actions/checkoutleaves the repo in detached HEAD state and the hand-rolledCommit the updated package.json and lockfilestep'sgit pushfails withfatal: You are not currently on a branch.The same latent bug exists in
manual_version_docs.yaml'sEndBug/add-and-commitstep (nonew_branchset). Neither has fired yet because nofeat/fix/perf/refactor/stylecommit has landed on master since the reusable-workflow extraction merged.Fix
manual_release_docs.yamlwithEndBug/add-and-commit@v10.new_branch: ${{ github.event.repository.default_branch }}in both workflows — EndBug does not handle detached HEAD by itself (its default push isgit push origin --set-upstreamwith no refspec, which fails the same way). Settingnew_branchmakes it create/checkout a local default branch at current HEAD before committing.